Messages in this thread | | | Date | Mon, 3 Jan 2022 09:47:40 -0800 | Subject | Re: [PATCH] locking/lockdep: Avoid potential access of invalid memory in lock_class | From | Bart Van Assche <> |
| |
On 1/2/22 18:35, Waiman Long wrote: > - WARN_ON_ONCE(!found); > - __lockdep_free_key_range(pf, key, 1); > - call_rcu_zapped(pf); > - graph_unlock(); > -out_irq: > + WARN_ON_ONCE(!found && debug_locks);
lockdep_unregister_key() should only be called for a registered key so I'd like to keep the WARN_ON_ONCE(!found) here instead of changing it into WARN_ON_ONCE(!found && debug_locks). Otherwise this patch looks good to me.
Thanks,
Bart.
| |