lkml.org 
[lkml]   [2022]   [Jan]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: r8188eu: remove unneeded ret variables
On Fri, Dec 31, 2021 at 10:55:27PM +0530, Abdun Nihaal wrote:
> Remove unneeded return variables in ioctl_linux.c that are initialized
> to 0 and are not assigned after. Instead, return 0 directly.

Almost all of these should not be returning a value at all, if they can
not fail and no one checks the values, right?

Please fix this up to be functions that return void, as that's the
correct thing to do here.

thanks,

greg k-h

\
 
 \ /
  Last update: 2022-01-03 14:29    [W:0.055 / U:1.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site