| Date | Mon, 3 Jan 2022 14:07:40 +0100 (CET) | From | Miroslav Benes <> | Subject | Re: [PATCH v9 01/15] modpost: fix removing numeric suffixes |
| |
On Thu, 23 Dec 2021, Alexander Lobakin wrote:
> For now, that condition from remove_dot(): > > if (m && (s[n + m] == '.' || s[n + m] == 0)) > > which was designed to test if it's a dot or a \0 after the suffix > is never satisfied. > This is due to that s[n + m] always points to the last digit of a > numeric suffix, not on the symbol next to it: > > param_set_uint.0, s[n + m] is '0', s[n + m + 1] is '\0' > > So it's off by one and was like that since 2014. > > `-z uniq-symbol` linker flag which we are planning to use to
`-z unique-symbol`
Miroslav
|