lkml.org 
[lkml]   [2022]   [Jan]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v9 01/15] modpost: fix removing numeric suffixes
On Thu, 23 Dec 2021, Alexander Lobakin wrote:

> For now, that condition from remove_dot():
>
> if (m && (s[n + m] == '.' || s[n + m] == 0))
>
> which was designed to test if it's a dot or a \0 after the suffix
> is never satisfied.
> This is due to that s[n + m] always points to the last digit of a
> numeric suffix, not on the symbol next to it:
>
> param_set_uint.0, s[n + m] is '0', s[n + m + 1] is '\0'
>
> So it's off by one and was like that since 2014.
>
> `-z uniq-symbol` linker flag which we are planning to use to

`-z unique-symbol`

Miroslav

\
 
 \ /
  Last update: 2022-01-03 14:09    [W:0.343 / U:0.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site