Messages in this thread | | | From | Chun-Kuang Hu <> | Date | Mon, 3 Jan 2022 20:39:15 +0800 | Subject | Re: [PATCH v2] drm/mediatek: Set default value for Panel Orientation connector prop. |
| |
Hi, Mark:
Mark Yacoub <markyacoub@chromium.org> 於 2021年12月30日 週四 上午2:44寫道: > > [Why] > Creating the prop uses UNKNOWN as the initial value, which is not a > supported value if the prop is to be supported. > > [How] > Set the panel orientation default value to NORMAL right after creating > the prop if no DSI panel exists. > Panels have their own orientations, and panel orientation can't be > overriden once initialized to a value. > > v1: > Set panel orientation only if DSI panel does not exist. > > Tested on Jacuzzi(MTK) > Fixes IGT@kms_properties@get_properties-sanity-{atomic,non-atomic} > > Signed-off-by: Mark Yacoub <markyacoub@chromium.org> > --- > drivers/gpu/drm/mediatek/mtk_dsi.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c > index 0ad7157660afa..9d33dd93118e0 100644 > --- a/drivers/gpu/drm/mediatek/mtk_dsi.c > +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c > @@ -1040,6 +1040,13 @@ static int mtk_dsi_encoder_init(struct drm_device *drm, struct mtk_dsi *dsi) > goto err_cleanup_encoder; > } > > + /* A drm_panel can have its own orientation. If there is no panel, set the > + * orientation to NORMAL. */ > + if (!dsi->panel) {
Please send patch based on latest kernel version. In latest kernel version, struct mtk_dsi{} has no member 'panel'.
Regards, Chun-Kuang.
> + drm_connector_set_panel_orientation( > + dsi->connector, DRM_MODE_PANEL_ORIENTATION_NORMAL); > + } > + > drm_connector_attach_encoder(dsi->connector, &dsi->encoder); > > return 0; > -- > 2.34.1.448.ga2b2bfdf31-goog >
| |