lkml.org 
[lkml]   [2022]   [Jan]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v16 2/7] arm64: dts: mt8183: add svs device information
From
Date
Hi Matthias,

On Thu, 2021-12-30 at 13:54 +0100, Matthias Brugger wrote:
>
> On 28/04/2021 08:54, Roger Lu wrote:
> > add compitable/reg/irq/clock/efuse setting in svs node
> >
> > Signed-off-by: Roger Lu <roger.lu@mediatek.com>
> > ---
> > arch/arm64/boot/dts/mediatek/mt8183.dtsi | 18 ++++++++++++++++++
> > 1 file changed, 18 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> > b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> > index 80519a145f13..441d617ece43 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> > @@ -657,6 +657,18 @@
> > status = "disabled";
> > };
> >
> > + svs: svs@1100b000 {
> > + compatible = "mediatek,mt8183-svs";
> > + reg = <0 0x1100b000 0 0x1000>;
> > + interrupts = <GIC_SPI 127 IRQ_TYPE_LEVEL_LOW>;
> > + clocks = <&infracfg CLK_INFRA_THERM>;
> > + clock-names = "main";
> > + nvmem-cells = <&svs_calibration>,
> > + <&thermal_calibration>;
> > + nvmem-cell-names = "svs-calibration-data",
> > + "t-calibration-data";
> > + };
> > +
> > pwm0: pwm@1100e000 {
> > compatible = "mediatek,mt8183-disp-pwm";
> > reg = <0 0x1100e000 0 0x1000>;
> > @@ -941,9 +953,15 @@
> > reg = <0 0x11f10000 0 0x1000>;
> > #address-cells = <1>;
> > #size-cells = <1>;
>
> Please add a new line between the different calibartion data, to improve
> readability.

No problem and thanks for the review.

> Regards,
> Matthias
>
> > + thermal_calibration: calib@180 {
> > + reg = <0x180 0xc>;
> > + };
> > mipi_tx_calibration: calib@190 {
> > reg = <0x190 0xc>;
> > };
> > + svs_calibration: calib@580 {
> > + reg = <0x580 0x64>;
> > + };
> > };
> >
> > u3phy: usb-phy@11f40000 {
> >

\
 
 \ /
  Last update: 2022-01-03 07:08    [W:0.074 / U:0.292 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site