Messages in this thread | | | Date | Sat, 29 Jan 2022 08:56:27 +0000 | From | Hyeonggon Yoo <> | Subject | Re: [PATCH] net: ena: Do not waste napi skb cache |
| |
On Tue, Jan 25, 2022 at 03:50:30PM +0200, Julian Wiedmann wrote: > On 25.01.22 11:34, Hyeonggon Yoo wrote: > > On Mon, Jan 24, 2022 at 10:50:05PM +0200, Shay Agroskin wrote: > >> > > [...] > > >> > >> I agree that the netdev_alloc_skb_ip_align() can become napi_alloc_skb(). > >> Hyeonggon Yoo, can you please apply this change as well to this patch? > >> > > > > Okay. I'll update and test it again. > > > > BTW, It seems netdev_alloc_skb_ip_align() is used to make some fields > > be aligned. It's okay to just ignore this? > > > > napi_alloc_skb() adds NET_IP_ALIGN internally, so you end up with the same alignment as before. >
Oh I was missing that. I updated the patch and tested again. Thank you!
> > > Thanks, > > Hyeonggon. > > > >> Thanks, > >> Shay > >> > >> > >>>>> else > >>>>> - skb = build_skb(first_frag, ENA_PAGE_SIZE); > >>>>> + skb = napi_build_skb(first_frag, ENA_PAGE_SIZE); > >>>>> if (unlikely(!skb)) { > >>>>> ena_increase_stat(&rx_ring->rx_stats.skb_alloc_fail, 1, > >>>> >
| |