Messages in this thread | | | Subject | Re: [PATCH] scsi: megaraid: cleanup formatting of megaraid | From | Joe Perches <> | Date | Fri, 28 Jan 2022 11:11:55 -0800 |
| |
On Fri, 2022-01-28 at 09:59 -0800, Tom Rix wrote: > On 1/28/22 9:42 AM, Bart Van Assche wrote: > > On 1/27/22 07:19, trix@redhat.com wrote: > > > From: Tom Rix <trix@redhat.com> > > > > > > checkpatch reports several hundred formatting errors. > > > Run these files through clang-format and knock off > > > some of them. > > > > Isn't this the kind of patches that carries more risk than value?
Risk for whitespace style reformatting patches is quite low.
Nominally, clang-format changes should not produce a different compiled object file unless __LINE__/__DATE__/__TIME__ style changes occur.
If it does, the clang-format tool is broken.
> > Additionally, this patch conflicts with a patch series that I plan to > > post soon. [] > Long term, it would be good have a reliable way to automatically fix > either new files or really broken old files.
That's really a maintainer preference no?
Especially so for any automation.
| |