Messages in this thread | | | Subject | Re: [PATCH v3] kselftest: Fix vdso_test_abi return status | From | Shuah Khan <> | Date | Fri, 28 Jan 2022 10:35:04 -0700 |
| |
On 1/28/22 7:44 AM, Cristian Marussi wrote: > On Fri, Jan 28, 2022 at 01:07:01PM +0000, Vincenzo Frascino wrote: >> vdso_test_abi contains a batch of tests that verify the validity of the >> vDSO ABI. >> >> When a vDSO symbol is not found the relevant test is skipped reporting >> KSFT_SKIP. All the tests return values are then added in a single >> variable which is checked to verify failures. This approach can have >> side effects which result in reporting the wrong kselftest exit status. >> >> Fix vdso_test_abi verifying the return code of each test separately. >> >> Cc: Shuah Khan <shuah@kernel.org> >> Cc: Andy Lutomirski <luto@kernel.org> >> Cc: Thomas Gleixner <tglx@linutronix.de> >> Reported-by: Cristian Marussi <cristian.marussi@arm.com> >> Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com> >> --- > > Hi, > > LGTM. > > Tested-by: Cristian Marussi <cristian.marussi@arm.com> > > Thanks, > Cristian
Thank you both. Will queue this up for 5.17 rc3.
thanks, -- Shuah
| |