lkml.org 
[lkml]   [2022]   [Jan]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] pinctrl: bcm2835: Fix a few error paths
On Thu, Jan 27, 2022 at 01:50:31PM -0800, Florian Fainelli wrote:
> After commit 266423e60ea1 ("pinctrl: bcm2835: Change init order for gpio
> hogs") a few error paths would not unwind properly the registration of
> gpio ranges. Correct that by assigning a single error label and goto it
> whenever we encounter a fatal error.

> 1 file changed, 15 insertions(+), 8 deletions(-)

While this seems legit per se, my eyes caught this:


> if (!girq->parents) {
> - pinctrl_remove_gpio_range(pc->pctl_dev, &pc->gpio_range);
> - return -ENOMEM;
> + err = -ENOMEM;
> + goto out_remove;

Non-devm....

> }
>
> if (is_7211) {
> pc->wake_irq = devm_kcalloc(dev, BCM2835_NUM_IRQS,
> sizeof(*pc->wake_irq),
> GFP_KERNEL);

...followed by devm.

It means more ordering bugs in the ->remove() and error path are lurking
around. Can you double check and be sure that we do not have a case where
non-devm registration code followed by devm?

If that is the case it has to be fixed as well.

> - if (!pc->wake_irq)
> - return -ENOMEM;
> + if (!pc->wake_irq) {
> + err = -ENOMEM;
> + goto out_remove;
> + }
> }


--
With Best Regards,
Andy Shevchenko


\
 
 \ /
  Last update: 2022-01-28 15:37    [W:0.050 / U:0.804 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site