Messages in this thread | | | Subject | Re: [PATCH] vchiq-mmal: Remove redundant 'flush_workqueue()' calls | From | Stefan Wahren <> | Date | Fri, 28 Jan 2022 12:51:10 +0100 |
| |
Am 28.01.22 um 08:03 schrieb Dan Carpenter: > On Thu, Jan 27, 2022 at 01:35:09PM +0100, Stefan Wahren wrote: >> Hi, >> >> Am 27.01.22 um 02:44 schrieb cgel.zte@gmail.com: >>> From: "Minghao Chi (CGEL ZTE)" <chi.minghao@zte.com.cn> >>> >>> 'destroy_workqueue()' already drains the queue before destroying it, >>> so there is no need to flush it explicitly. >>> >>> Remove the redundant 'flush_workqueue()' calls. >> are you sure that drain_workqueue() is the same as flush_workqueue()? > drain_workqueue() calls flush_workqueue() repeatedly.
sorry, i overlooked this
I'm fine with the patch
> > regards, > dan carpenter > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
| |