lkml.org 
[lkml]   [2022]   [Jan]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
SubjectRe: [PATCH 07/16] tools/include: Add io.h stub
From
Date
On Thu, 2022-01-27 at 14:09 +0000, Matthew Wilcox wrote:
> On Thu, Jan 27, 2022 at 02:21:25PM +0100, Karolina Drobnik wrote:
> > Add a dummy io.h header.
>
> Rather begs the question of what memblock.c needs from linux/io.h.
>
> Wouldn't it be better to:
>
> +++ b/mm/memblock.c
> @@ -18,7 +18,6 @@
>  #include <linux/memblock.h>
>
>  #include <asm/sections.h>
> -#include <linux/io.h>
>
>  #include "internal.h"
>

That was something I considered in the very beginning, but didn't have
a chance to verify it works for all architectures. I can take a look
after I'm finished with other v2 changes.

> (allmodconfig on x86-64 builds fine with this; I have not done an
> extended sweep of other arches / build options).


\
 
 \ /
  Last update: 2022-01-28 12:22    [W:0.957 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site