Messages in this thread Patch in this message | | | Subject | Re: [PATCH 07/16] tools/include: Add io.h stub | From | Karolina Drobnik <> | Date | Fri, 28 Jan 2022 12:21:59 +0100 |
| |
On Thu, 2022-01-27 at 14:09 +0000, Matthew Wilcox wrote: > On Thu, Jan 27, 2022 at 02:21:25PM +0100, Karolina Drobnik wrote: > > Add a dummy io.h header. > > Rather begs the question of what memblock.c needs from linux/io.h. > > Wouldn't it be better to: > > +++ b/mm/memblock.c > @@ -18,7 +18,6 @@ > #include <linux/memblock.h> > > #include <asm/sections.h> > -#include <linux/io.h> > > #include "internal.h" >
That was something I considered in the very beginning, but didn't have a chance to verify it works for all architectures. I can take a look after I'm finished with other v2 changes.
> (allmodconfig on x86-64 builds fine with this; I have not done an > extended sweep of other arches / build options).
| |