lkml.org 
[lkml]   [2022]   [Jan]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 12/35] mm: separate mmap locked assertion from find_vma
Hi Michel,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v5.17-rc1 next-20220128]
[cannot apply to tip/x86/mm arm64/for-next/core powerpc/next hnaz-mm/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Michel-Lespinasse/Speculative-page-faults/20220128-212122
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 145d9b498fc827b79c1260b4caa29a8e59d4c2b9
config: arm-randconfig-c002-20220124 (https://download.01.org/0day-ci/archive/20220129/202201290752.GKB0XPLn-lkp@intel.com/config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 33b45ee44b1f32ffdbc995e6fec806271b4b3ba4)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm cross compiling tool for clang build
# apt-get install binutils-arm-linux-gnueabi
# https://github.com/0day-ci/linux/commit/d9d603df22594c13d340d1036653e0b039f975eb
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Michel-Lespinasse/Speculative-page-faults/20220128-212122
git checkout d9d603df22594c13d340d1036653e0b039f975eb
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> mm/nommu.c:666:24: error: redefinition of 'find_vma'
struct vm_area_struct *find_vma(struct mm_struct *mm, unsigned long addr)
^
include/linux/mm.h:2759:24: note: previous definition is here
struct vm_area_struct *find_vma(struct mm_struct *mm, unsigned long addr)
^
1 error generated.


vim +/find_vma +666 mm/nommu.c

8feae13110d60cc David Howells 2009-01-08 661
8feae13110d60cc David Howells 2009-01-08 662 /*
8feae13110d60cc David Howells 2009-01-08 663 * look up the first VMA in which addr resides, NULL if none
c1e8d7c6a7a682e Michel Lespinasse 2020-06-08 664 * - should be called with mm->mmap_lock at least held readlocked
8feae13110d60cc David Howells 2009-01-08 665 */
8feae13110d60cc David Howells 2009-01-08 @666 struct vm_area_struct *find_vma(struct mm_struct *mm, unsigned long addr)
8feae13110d60cc David Howells 2009-01-08 667 {
8feae13110d60cc David Howells 2009-01-08 668 struct vm_area_struct *vma;
8feae13110d60cc David Howells 2009-01-08 669
8feae13110d60cc David Howells 2009-01-08 670 /* check the cache first */
615d6e8756c8714 Davidlohr Bueso 2014-04-07 671 vma = vmacache_find(mm, addr);
615d6e8756c8714 Davidlohr Bueso 2014-04-07 672 if (likely(vma))
8feae13110d60cc David Howells 2009-01-08 673 return vma;
8feae13110d60cc David Howells 2009-01-08 674
e922c4c5360980b Namhyung Kim 2011-05-24 675 /* trawl the list (there may be multiple mappings in which addr
8feae13110d60cc David Howells 2009-01-08 676 * resides) */
e922c4c5360980b Namhyung Kim 2011-05-24 677 for (vma = mm->mmap; vma; vma = vma->vm_next) {
8feae13110d60cc David Howells 2009-01-08 678 if (vma->vm_start > addr)
8feae13110d60cc David Howells 2009-01-08 679 return NULL;
8feae13110d60cc David Howells 2009-01-08 680 if (vma->vm_end > addr) {
615d6e8756c8714 Davidlohr Bueso 2014-04-07 681 vmacache_update(addr, vma);
8feae13110d60cc David Howells 2009-01-08 682 return vma;
8feae13110d60cc David Howells 2009-01-08 683 }
8feae13110d60cc David Howells 2009-01-08 684 }
8feae13110d60cc David Howells 2009-01-08 685
8feae13110d60cc David Howells 2009-01-08 686 return NULL;
8feae13110d60cc David Howells 2009-01-08 687 }
8feae13110d60cc David Howells 2009-01-08 688 EXPORT_SYMBOL(find_vma);
8feae13110d60cc David Howells 2009-01-08 689

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

\
 
 \ /
  Last update: 2022-01-29 01:09    [W:1.883 / U:1.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site