lkml.org 
[lkml]   [2022]   [Jan]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] arch:x86:pci:irq.c: Improve log message when IRQ cannot be identified
On 1/28/22 12:48, Brent Spillner wrote:
> It seems like the multiline string literal is your main pain point--- would
>
> +#ifdef CONFIG_ACPI
> + if (acpi_noirq)
> + msg = "; consider removing acpi=noirq";
> + else
> + msg = "; recommend verifying UEFI/BIOS
> IRQ options";
> +#else
> + msg = "; recommend verifying UEFI/BIOS IRQ
> options or enabling ACPI";
> +#endif
>
> be OK without going to IS_ENABLED()? (Personally, I think the #ifdef
> style is more readable.)

I think that's _better_ than what was in the patch. But, even with it,
I still think the #ifdef mess borders on unreadable.

But, if Bjorn likes it, then go for it. :)

\
 
 \ /
  Last update: 2022-01-28 22:37    [W:0.088 / U:0.164 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site