Messages in this thread | | | Date | Thu, 27 Jan 2022 08:56:27 -0800 | From | Jakub Kicinski <> | Subject | Re: [PATCH net-next v1 1/1] usbnet: add devlink support |
| |
On Thu, 27 Jan 2022 16:43:53 +0100 Andrew Lunn wrote: > On Thu, Jan 27, 2022 at 12:07:42PM +0100, Oleksij Rempel wrote: > > The weakest link of usbnet devices is the USB cable. Currently there is > > no way to automatically detect cable related issues except of analyzing > > kernel log, which would differ depending on the USB host controller. > > > > The Ethernet packet counter could potentially show evidence of some USB > > related issues, but can be Ethernet related problem as well. > > I don't know the usbnet drivers very well. A quick look suggests they > don't support statistics via ethtool -S. So you could make use of that > to return statistics about USB error events.
On using devlink health - it is great when you want to attach some extra info to the error report. If you're just counting different types of errors seems like an overkill.
> However, GregKH point still stands, maybe such statistics should be > made for all USB devices, and be available in /sys/bus/usb/devices/*
| |