Messages in this thread | | | From | Alexander Lobakin <> | Subject | [PATCH v2 net-next 0/4] ice: switch: debloat packet templates code | Date | Thu, 27 Jan 2022 16:40:05 +0100 |
| |
This hunts down several places around packet templates/dummies for switch rules which are either repetitive, fragile or just not really readable code. It's a common need to add new packet templates and to review such changes as well, try to simplify both with the help of a pair macros and aliases.
bloat-o-meter is happy about that (built w/ LLVM 13):
add/remove: 0/1 grow/shrink: 2/0 up/down: 148/-202 (-54) Function old new delta ice_add_adv_rule 2383 2529 +146 ice_fill_adv_dummy_packet 289 291 +2 ice_adv_add_update_vsi_list 202 - -202 Total: Before=395813, After=395759, chg -0.01%
Diffstat also looks nice, and adding new packet templates now takes less lines.
We'll probably come out with dynamic template crafting in a while, but for now let's improve what we have currently.
Note: this will conflict with [1] going through net-next, a followup will be sent once accepted.
From v1 ([0]): - rebase on top of the latest next-queue (to fix #3 not applying); - adjust the kdoc accordingly to the function proto changes in #3; - no functional changes.
[0] https://lore.kernel.org/netdev/20220124173116.739083-1-alexandr.lobakin@intel.com [1] https://lore.kernel.org/netdev/20220127125525.125805-1-marcin.szycik@linux.intel.com
Alexander Lobakin (4): ice: switch: add and use u16[] aliases to ice_adv_lkup_elem::{h,m}_u ice: switch: unobscurify bitops loop in ice_fill_adv_dummy_packet() ice: switch: use a struct to pass packet template params ice: switch: use convenience macros to declare dummy pkt templates
drivers/net/ethernet/intel/ice/ice_switch.c | 273 ++++++++------------ drivers/net/ethernet/intel/ice/ice_switch.h | 12 +- 2 files changed, 123 insertions(+), 162 deletions(-)
-- 2.34.1
| |