Messages in this thread | | | From | Rob Herring <> | Subject | Re: [PATCH] dt-bindings: net: convert net/cortina,gemini-ethernet to yaml | Date | Thu, 27 Jan 2022 08:03:05 -0600 |
| |
On Wed, 26 Jan 2022 21:11:28 +0000, Corentin Labbe wrote: > Converts net/cortina,gemini-ethernet.txt to yaml > This permits to detect some missing properties like interrupts > > Signed-off-by: Corentin Labbe <clabbe@baylibre.com> > --- > .../bindings/net/cortina,gemini-ethernet.txt | 92 ------------ > .../bindings/net/cortina,gemini-ethernet.yaml | 138 ++++++++++++++++++ > 2 files changed, 138 insertions(+), 92 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/net/cortina,gemini-ethernet.txt > create mode 100644 Documentation/devicetree/bindings/net/cortina,gemini-ethernet.yaml >
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/cortina,gemini-ethernet.yaml: patternProperties:^ethernet-port@[0-9]+$:properties:reg: 'oneOf' conditional failed, one must be fixed: [{'description': 'DMA/TOE memory'}, {'description': 'GMAC memory area of the port'}] is too long [{'description': 'DMA/TOE memory'}, {'description': 'GMAC memory area of the port'}] is too short False schema does not allow 2 1 was expected hint: "minItems" is only needed if less than the "items" list length from schema $id: http://devicetree.org/meta-schemas/items.yaml# /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/cortina,gemini-ethernet.yaml: ignoring, error in schema: patternProperties: ^ethernet-port@[0-9]+$: properties: reg Documentation/devicetree/bindings/net/cortina,gemini-ethernet.example.dt.yaml:0:0: /example-0/ethernet@60000000: failed to match any schema with compatible: ['cortina,gemini-ethernet'] Documentation/devicetree/bindings/net/cortina,gemini-ethernet.example.dt.yaml:0:0: /example-0/ethernet@60000000/ethernet-port@0: failed to match any schema with compatible: ['cortina,gemini-ethernet-port'] Documentation/devicetree/bindings/net/cortina,gemini-ethernet.example.dt.yaml:0:0: /example-0/ethernet@60000000/ethernet-port@1: failed to match any schema with compatible: ['cortina,gemini-ethernet-port']
doc reference errors (make refcheckdocs): MAINTAINERS: Documentation/devicetree/bindings/net/cortina,gemini-ethernet.txt
See https://patchwork.ozlabs.org/patch/1584680
This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date:
pip3 install dtschema --upgrade
Please check and re-submit.
| |