Messages in this thread | | | Date | Thu, 27 Jan 2022 15:44:43 +0200 | From | Laurent Pinchart <> | Subject | Re: [PATCH] media: adv7180: Fix media bus format |
| |
Hi Jean-Michel,
Thank you for the patch.
On Thu, Jan 27, 2022 at 11:09:47AM +0100, Jean-Michel Hautbois wrote: > MEDIA_BUS_FMT_UYVY8_2X8 isn't correct for CSI-2. Use > MEDIA_BUS_FMT_UYVY8_1X16 instead.
While that's right, I expect it will cause regressions. The driver probably needs to support for media bus codes.
> Signed-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com> > --- > drivers/media/i2c/adv7180.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/i2c/adv7180.c b/drivers/media/i2c/adv7180.c > index d9a99fcfacb1..cbededfb6b3f 100644 > --- a/drivers/media/i2c/adv7180.c > +++ b/drivers/media/i2c/adv7180.c > @@ -655,7 +655,7 @@ static int adv7180_enum_mbus_code(struct v4l2_subdev *sd, > if (code->index != 0) > return -EINVAL; > > - code->code = MEDIA_BUS_FMT_UYVY8_2X8; > + code->code = MEDIA_BUS_FMT_UYVY8_1X16; > > return 0; > } > @@ -665,7 +665,7 @@ static int adv7180_mbus_fmt(struct v4l2_subdev *sd, > { > struct adv7180_state *state = to_state(sd); > > - fmt->code = MEDIA_BUS_FMT_UYVY8_2X8; > + fmt->code = MEDIA_BUS_FMT_UYVY8_1X16; > fmt->colorspace = V4L2_COLORSPACE_SMPTE170M; > fmt->width = 720; > fmt->height = state->curr_norm & V4L2_STD_525_60 ? 480 : 576;
-- Regards,
Laurent Pinchart
| |