Messages in this thread | | | From | Christophe Leroy <> | Subject | Re: [PATCH 1/7] modules: Refactor within_module_core() and within_module_init() | Date | Thu, 27 Jan 2022 11:32:00 +0000 |
| |
Le 24/01/2022 à 13:32, Christoph Hellwig a écrit : > On Mon, Jan 24, 2022 at 09:22:15AM +0000, Christophe Leroy wrote: >> +static inline bool within_range(unsigned long addr, void *base, unsigned int size) > > Please avoid the overly long line. > > .. But given that this function only has a single caller I see no > point in factoring it out anyway.
I finally decided to drop this change from the series as it brings little added value.
Thanks Christophe
| |