Messages in this thread | | | Subject | Re: [PATCH RESEND 1/2] ARM: dts: imx6: phyFLEX: add missing pmic mfd subdevices | From | Andrej Picej <> | Date | Thu, 27 Jan 2022 07:28:27 +0100 |
| |
Hi Shawn,
On 26. 01. 22 10:24, Shawn Guo wrote: > On Thu, Dec 16, 2021 at 12:55:28PM +0100, Andrej Picej wrote: >> phyFLEX PMIC DA9063 has also RTC and watchdog support. Add both >> mfd subdevices so they can be used. >> >> Signed-off-by: Andrej Picej <andrej.picej@norik.com> >> --- >> arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi b/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi >> index f3236204cb5a..2ec154756bbc 100644 >> --- a/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi >> +++ b/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi >> @@ -205,6 +205,14 @@ vdd_mx6_high_reg: ldo11 { >> regulator-always-on; >> }; >> }; >> + >> + pmic_rtc: rtc { > > Maybe a more specific label like the following? > > da9063_rtc: rtc > > And it's more aligned with da9063_wdog below. > >> + compatible = "dlg,da9063-rtc"; >> + }; >> + >> + da9063_wdog: wdt { > > watchdog for the node name. >
I'll apply your suggestions and send v2. Do you agree that I also change the commit subject line to "ARM: dts: imx6qdl-phytec: ...", as you suggested in patch 2/2?
Thanks for your review.
Andrej
| |