Messages in this thread | | | Subject | Re: [PATCH v11 2/3] dts: arm64: mt8183: add Mediatek MDP3 nodes | From | AngeloGioacchino Del Regno <> | Date | Thu, 27 Jan 2022 11:57:23 +0100 |
| |
Il 25/01/22 09:20, moudy ho ha scritto: > On Fri, 2022-01-21 at 12:58 +0100, AngeloGioacchino Del Regno wrote: >> Il 05/01/22 10:37, Moudy Ho ha scritto: >>> Add device nodes for Media Data Path 3 (MDP3) modules. >>> >>> Signed-off-by: Moudy Ho <moudy.ho@mediatek.com> >>> --- >>> arch/arm64/boot/dts/mediatek/mt8183.dtsi | 108 >>> ++++++++++++++++++++++- >>> 1 file changed, 107 insertions(+), 1 deletion(-) >>> >>> diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi >>> b/arch/arm64/boot/dts/mediatek/mt8183.dtsi >>> index ba4584faca5a..b872ef1ff6b3 100644 >>> --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi >>> +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi >>> @@ -1325,6 +1325,79 @@ >>> mediatek,gce-client-reg = <&gce SUBSYS_1400XXXX >>> 0 0x1000>; >>> }; >>> >>> + mdp3_rdma0: mdp3_rdma0@14001000 { >>> + compatible = "mediatek,mt8183-mdp3", >>> + "mediatek,mt8183-mdp3-rdma0"; >>> + mediatek,scp = <&scp>; >>> + mediatek,mdp3-comps = "mediatek,mt8183-mdp3- >>> dl1", >>> + "mediatek,mt8183-mdp3- >>> dl2", >>> + "mediatek,mt8183-mdp3- >>> path1", >>> + "mediatek,mt8183-mdp3- >>> path2", >>> + "mediatek,mt8183-mdp3- >>> imgi", >>> + "mediatek,mt8183-mdp3- >>> exto"; >>> + reg = <0 0x14001000 0 0x1000>, >>> + <0 0x14000000 0 0x1000>, >>> + <0 0x14005000 0 0x1000>, >>> + <0 0x14006000 0 0x1000>, >>> + <0 0x15020000 0 0x1000>; >>> + mediatek,gce-client-reg = <&gce SUBSYS_1400XXXX >>> 0x1000 0x1000>, >>> + <&gce SUBSYS_1400XXXX >>> 0 0x1000>, >>> + <&gce SUBSYS_1400XXXX >>> 0x5000 0x1000>, >>> + <&gce SUBSYS_1400XXXX >>> 0x6000 0x1000>, >>> + <&gce SUBSYS_1502XXXX >>> 0 0x1000>; >>> + power-domains = <&spm >>> MT8183_POWER_DOMAIN_DISP>; >>> + clocks = <&mmsys CLK_MM_MDP_RDMA0>, >>> + <&mmsys CLK_MM_MDP_RSZ1>, >>> + <&mmsys CLK_MM_MDP_DL_TXCK>, >>> + <&mmsys CLK_MM_MDP_DL_RX>, >>> + <&mmsys CLK_MM_IPU_DL_TXCK>, >>> + <&mmsys CLK_MM_IPU_DL_RX>; >>> + iommus = <&iommu M4U_PORT_MDP_RDMA0>; >>> + mediatek,mmsys = <&mmsys>; >>> + mediatek,mm-mutex = <&mutex>; >>> + mediatek,mailbox-gce = <&gce>; >>> + mboxes = <&gce 20 CMDQ_THR_PRIO_LOWEST 0>, >>> + <&gce 21 CMDQ_THR_PRIO_LOWEST>, >>> + <&gce 22 CMDQ_THR_PRIO_LOWEST>, >>> + <&gce 23 CMDQ_THR_PRIO_LOWEST>; >> >> Hello Moudy, >> the mboxes for gce 21, 22, 23 are missing the third cell. Please fix. >> >> Regards, >> Angelo > > Hi Angelo, > Thanks for the reminder, but I'm a bit confused, the previous > version(v10) mentioned that the current upstream mbox has only 2 > cells. > So I should follow this rule to remove the extra 0 in the first item as > follows: > + mboxes = <&gce 20 CMDQ_THR_PRIO_LOWEST>, > + <&gce 21 CMDQ_THR_PRIO_LOWEST>, > + <&gce 22 CMDQ_THR_PRIO_LOWEST>, > + <&gce 23 CMDQ_THR_PRIO_LOWEST>; > > Thanks, > Moudy Ho
Hello Moudy, I'm sorry for this confusion and you are totally right in the proposed solution, which is the exact opposite of what I said.
Thanks for understanding, Angelo
>> >>> + gce-subsys = <&gce 0x14000000 SUBSYS_1400XXXX>, >>> + <&gce 0x14010000 SUBSYS_1401XXXX>, >>> + <&gce 0x14020000 SUBSYS_1402XXXX>, >>> + <&gce 0x15020000 SUBSYS_1502XXXX>; >>> + }; >>> + >> >> >
| |