Messages in this thread | | | Date | Thu, 27 Jan 2022 10:20:09 +0000 | From | Srinivas Kandagatla <> | Subject | Re: [PATCH 0/4] ASoC: qcom: fixes for Qualcomm codecs and q6apm |
| |
Thanks Mark,
On 26/01/2022 13:29, Mark Brown wrote: > On Wed, Jan 26, 2022 at 11:35:45AM +0000, Srinivas Kandagatla wrote: > >> Some recent testing found few issues with wcd938x and lpass-tx codec drivers. >> WCD938x was accessing array out of boundaries resulting in corruption and >> system crashes along with not handling kcontrol put return values correctly >> and rx-macro had incorrect sidetone registers offsets. One final fix in q6apm >> to add a check if graph started before stopping it. > > You probably want to run the new mixer kselftest on these devices,
Yes, this is really good test indeed already found few issues with existing mixers. I will test this on all the Qualcomm boards and get back with some fixes.
I also made some improvements to the mixer test to not keep writing new values to controls that have returned -EPERM in cases like where put callback is NULL, In my case I have a Impedance value read only control whose value range is MAX_INT.
--srini
> including with the patch I posted the other day testing out of bounds > writes. It doesn't cover change notifications yet, you might want to > set up some automation for that for whenever someone gets round to > adding coverage.
| |