Messages in this thread | | | Date | Thu, 27 Jan 2022 11:04:14 +0100 | From | Aleksa Vučković <> | Subject | Re: [PATCH] drivers: dio: Fixed coding style issues |
| |
Hey,
I made a really simple patch fixing coding style errors. Could you please review it, and tell me how to prevent errors like this:
> - Your patch did many different things all at once, making it > difficult to review.
from happening in the future.
Should i split changes into 2 patches? One for upper half and one for lower half of the file I changed?
Many lines have multiple errors, so if I fix one error, I also need to fix the other one. So I can not just have patch fixing one thing at the time. Should I try to fix error in this manner: [PATCH 1/3] fix lines that have ONLY spaces to tabs error [PATCH 2/3] fix lines that have ONLY braces error [PATCH 3/3] fix lines that have spaces to tabs error AND braces error or should I have a different approach?
Sorry for bothering, this is my first time submitting patches.
Thanks in advance,
Aleksa
| |