lkml.org 
[lkml]   [2022]   [Jan]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [v5 PATCH] block: introduce block_rq_error tracepoint
On Wed, Jan 26, 2022 at 10:51:53AM -0800, Yang Shi wrote:
> + __entry->dev = rq->q->disk ? disk_devt(rq->q->disk) : 0;
> + __assign_str(name, rq->q->disk ? rq->q->disk->disk_name : "?");

None f the other tracepoints has the disk name, why does this one need
it? And if you add it please avoid the overly long line.

> + __entry->sector = blk_rq_pos(rq);
> + __entry->nr_sector = nr_bytes >> 9;
> + __entry->error = blk_status_to_errno(error);

This still converts the block status to an errno.

\
 
 \ /
  Last update: 2022-01-27 10:54    [W:0.093 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site