lkml.org 
[lkml]   [2022]   [Jan]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 2/3] kunit: consolidate KUNIT_INIT_BINARY_ASSERT_STRUCT macros
    On Tue, Jan 25, 2022 at 4:00 PM Daniel Latypov <dlatypov@google.com> wrote:
    >
    > We currently have 2 other versions of KUNIT_INIT_BINARY_ASSERT_STRUCT.
    > The only differences are that
    > * the format funcition they pass is different
    > * the types of left_val/right_val should be different (integral,
    > pointer, string).
    >
    > The latter doesn't actually matter since these macros are just plumbing
    > them along to KUNIT_ASSERTION where they will get type checked.
    >
    > So combine them all into a single KUNIT_INIT_BINARY_ASSERT_STRUCT that
    > now also takes the format function as a parameter.
    >
    > Signed-off-by: Daniel Latypov <dlatypov@google.com>

    Reviewed-by: Brendan Higgins <brendanhiggins@google.com>

    \
     
     \ /
      Last update: 2022-01-27 22:32    [W:2.358 / U:0.684 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site