Messages in this thread | | | From | Paul Moore <> | Date | Wed, 26 Jan 2022 14:34:28 -0500 | Subject | Re: [PATCH 3/9] selinux: declare name parameter of hash_eval const |
| |
On Tue, Jan 25, 2022 at 9:14 AM Christian Göttsche <cgzones@googlemail.com> wrote: > > String literals are passed as second argument to hash_eval(). Also the > parameter is already declared const in the DEBUG_HASHES configuration. > > Reported by clang [-Wwrite-strings]: > > security/selinux/ss/policydb.c:1881:26: error: passing 'const char [8]' to parameter of type 'char *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers] > hash_eval(&p->range_tr, rangetr); > ^~~~~~~~~ > security/selinux/ss/policydb.c:707:55: note: passing argument to parameter 'hash_name' here > static inline void hash_eval(struct hashtab *h, char *hash_name) > ^ > security/selinux/ss/policydb.c:2099:32: error: passing 'const char [11]' to parameter of type 'char *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers] > hash_eval(&p->filename_trans, filenametr); > ^~~~~~~~~~~~ > security/selinux/ss/policydb.c:707:55: note: passing argument to parameter 'hash_name' here > static inline void hash_eval(struct hashtab *h, char *hash_name) > ^ > > Signed-off-by: Christian Göttsche <cgzones@googlemail.com> > --- > security/selinux/ss/policydb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)
Merged into selinux/next, thanks!
-- paul-moore.com
| |