Messages in this thread | | | Date | Wed, 26 Jan 2022 07:52:20 -0800 | From | Jakub Kicinski <> | Subject | Re: [PATCH v2] net: ena: Do not waste napi skb cache |
| |
On Wed, 26 Jan 2022 13:16:41 +0000 Hyeonggon Yoo wrote: > By profiling, discovered that ena device driver allocates skb by > build_skb() and frees by napi_skb_cache_put(). Because the driver > does not use napi skb cache in allocation path, napi skb cache is > periodically filled and flushed. This is waste of napi skb cache. > > As ena_alloc_skb() is called only in napi, Use napi_build_skb() > and napi_alloc_skb() when allocating skb. > > This patch was tested on aws a1.metal instance. > > [ jwiedmann.dev@gmail.com: Use napi_alloc_skb() instead of > netdev_alloc_skb_ip_align() to keep things consistent. ] > > Signed-off-by: Hyeonggon Yoo <42.hyeyoo@gmail.com>
It seems you missed CCing netdev@, you'll need to repost. You can keep the ack from Shay.
| |