lkml.org 
[lkml]   [2022]   [Jan]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4] drivers: thermal: clear all mitigation when thermal zone is disabled
Hi Manaf,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on rafael-pm/thermal]
[also build test WARNING on v5.17-rc1 next-20220125]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Manaf-Meethalavalappu-Pallikunhi/drivers-thermal-clear-all-mitigation-when-thermal-zone-is-disabled/20220126-004720
base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git thermal
config: nios2-randconfig-m031-20220124 (https://download.01.org/0day-ci/archive/20220126/202201262251.KzdCvJYy-lkp@intel.com/config)
compiler: nios2-linux-gcc (GCC) 11.2.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

smatch warnings:
drivers/thermal/gov_step_wise.c:189 step_wise_unbind() warn: inconsistent indenting

vim +189 drivers/thermal/gov_step_wise.c

169
170 /**
171 * step_wise_unbind() - unbind the step_wise governor to a thermal zone
172 * @tz: thermal zone to unbind it to
173 *
174 * Clear all previous throttling and reset passive counter.
175 *
176 */
177 static void step_wise_unbind(struct thermal_zone_device *tz)
178 {
179 struct thermal_instance *instance;
180
181 dev_dbg(&tz->device, "Unbinding from thermal zone %d\n", tz->id);
182
183 mutex_lock(&tz->lock);
184 tz->passive = 0;
185 list_for_each_entry(instance, &tz->thermal_instances, tz_node) {
186 instance->initialized = false;
187 instance->target = THERMAL_NO_TARGET;
188 mutex_lock(&instance->cdev->lock);
> 189 __thermal_cdev_update(instance->cdev);
190 mutex_unlock(&instance->cdev->lock);
191 }
192 mutex_unlock(&tz->lock);
193 }
194

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

\
 
 \ /
  Last update: 2022-01-26 16:50    [W:0.074 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site