Messages in this thread | | | From | "Alim Akhtar" <> | Subject | RE: [PATCH v5 00/16] Add support for Tesla Full Self-Driving (FSD) SoC | Date | Wed, 26 Jan 2022 12:20:51 +0530 |
| |
Hi Krzysztof
>-----Original Message----- >From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@canonical.com] >Sent: Tuesday, January 25, 2022 10:56 PM >To: Alim Akhtar <alim.akhtar@samsung.com>; linux-arm- >kernel@lists.infradead.org; linux-kernel@vger.kernel.org >Cc: soc@kernel.org; linux-clk@vger.kernel.org; devicetree@vger.kernel.org; >olof@lixom.net; arnd@arndb.de; linus.walleij@linaro.org; >catalin.marinas@arm.com; robh+dt@kernel.org; s.nawrocki@samsung.com; >linux-samsung-soc@vger.kernel.org; pankaj.dubey@samsung.com; >sboyd@kernel.org >Subject: Re: [PATCH v5 00/16] Add support for Tesla Full Self-Driving (FSD) SoC > >On 25/01/2022 18:12, Krzysztof Kozlowski wrote: >> On 24/01/2022 15:16, Alim Akhtar wrote: >>> Adds basic support for the Tesla Full Self-Driving (FSD) SoC. This >>> SoC contains three clusters of four Cortex-A72 CPUs, as well as >>> several IPs. >>> >>> Patches 1 to 9 provide support for the clock controller (which is >>> designed similarly to Exynos SoCs). >>> >>> The remaining changes provide pinmux support, initial device tree support. >>> >>> - Changes since v4 >>> * fixed 'make dtbs_check' warnings on patch 14/16 >>> >>> - Changes since v3 >>> * Addressed Stefen's review comments on patch 14/16 >>> * Fixed kernel test robot warning on patch 04/16 >>> * rebsaed this series on Krzysztof's pinmux new binding schema work >>> [1] >>> >>> - Changes since v2 >>> * Addressed Krzysztof's and Stephen's review comments >>> * Added Reviewed-by and Acked-by tags >>> * Rebased on next-20220120 >>> >>> - Changes since v1 >>> * fixed make dt_binding_check error as pointed by Rob >>> * Addressed Krzysztof's and Rob's review comments >>> * Added Reviewed-by and Acked-by tags >>> * Dropped SPI, MCT and ADC from this series (to be posted in small >>> sets) >>> >>> NOTE: These patches are based on Krzysztof's pinmux for-next branch >>> commit 832ae134ccc1 ("pinctrl: samsung: add support for Exynos850 and >>> ExynosAutov9 wake-ups") [1] >>> https://git.kernel.org/pub/scm/linux/kernel/git/pinctrl/samsung.git/l >>> og/?h=for-next >>> >>> >> >> Thanks, applied DTS/soc and pinctrl patches. >> >> I expect Sylwester will pick up the clock ones. Otherwise please let >> me know to pick it up as well. > >I forgot that clock macros are used in DTS. This does not compile and I cannot >take drivers into DTS branch. > >Alim, >DTS changes dropped. Please resend with the same trick we did for >Exynos850 board - hard-coded clock IDs as defines. See: > >https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git/diff/arch/arm6 >4/boot/dts/exynos/exynos850.dtsi?h=samsung-dt64-5.17- >2&id=e3493220fd3e474abcdcefbe14fb60485097ce06 > Ok, I will resend patch 14 and 15 (DTS changes) only as suggested above.
> >Best regards, >Krzysztof
| |