Messages in this thread Patch in this message | | | From | Andy Shevchenko <> | Subject | [PATCH v3 3/3] vsprintf: Move space out of string literals in fourcc_string() | Date | Wed, 26 Jan 2022 16:19:17 +0200 |
| |
The literals "big-endian" and "little-endian" may be potentially occurred in other places. Dropping space allows linker to "compress" them by using only a single copy.
Rasmus suggested, while at it, replacing strcpy() + strlen() by p = stpcpy(), which is done here as well.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com> --- v3: no changes lib/vsprintf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/vsprintf.c b/lib/vsprintf.c index 4e8f3e9acb99..e2a1d89f1a5c 100644 --- a/lib/vsprintf.c +++ b/lib/vsprintf.c @@ -1781,8 +1781,8 @@ char *fourcc_string(char *buf, char *end, const u32 *fourcc, *p++ = isascii(c) && isprint(c) ? c : '.'; } - strcpy(p, orig & BIT(31) ? " big-endian" : " little-endian"); - p += strlen(p); + *p++ = ' '; + p = stpcpy(p, orig & BIT(31) ? "big-endian" : "little-endian"); *p++ = ' '; *p++ = '('; -- 2.34.1
| |