Messages in this thread | | | Date | Wed, 26 Jan 2022 14:44:15 +0100 | Subject | Re: [PATCH] brcmfmac: Fix a NULL pointer dereference in brcmf_of_probe() | From | Arend van Spriel <> |
| |
On 1/24/2022 5:50 PM, 'Zhou Qingyang' via BRCM80211-DEV-LIST,PDL wrote: > In brcmf_of_probe(), the return value of devm_kzalloc() is assigned to > board_type and there is a dereference of it in strcpy() right after > that. devm_kzalloc() could return NULL on failure of allocation, which > could lead to NULL pointer dereference. > > Fix this bug by adding a NULL check of board_type. > > This bug was found by a static analyzer. > > Builds with 'make allyesconfig' show no new warnings, > and our static analyzer no longer warns about this code
Thanks for this suggestion. However, this has been addressed already by this patch [1].
Regards, Arend
[1] https://patchwork.kernel.org/project/linux-wireless/patch/20220117142919.207370-8-marcan@marcan.st/ [unhandled content-type:application/pkcs7-signature] | |