Messages in this thread | | | Date | Wed, 26 Jan 2022 14:04:22 +0100 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH v2 2/2] usb: ulpi: Call of_node_put correctly |
| |
On Tue, Jan 25, 2022 at 11:53:58AM -0500, Sean Anderson wrote: > Hi Heikki, > > On 1/25/22 4:18 AM, Heikki Krogerus wrote: > > On Mon, Jan 24, 2022 at 12:33:44PM -0500, Sean Anderson wrote: > >> of_node_put should always be called on device nodes gotten from > >> of_get_*. Additionally, it should only be called after there are no > >> remaining users. To address the first issue, call of_node_put if later > >> steps in ulpi_register fail. To address the latter, call of_node_put > >> only after calling device_unregister. > > > > This looks like a fix, but you don't have the fix tag. > > You're right this should have > > Fixes: ef6a7bcfb01c ("usb: ulpi: Support device discovery via DT")
Please resend this as 2 independent patches as they should not depend on each other, allowing this one to be backported, but the debugfs addition added only to 5.18-rc1.
thanks,
greg k-h
| |