Messages in this thread | | | Date | Wed, 26 Jan 2022 13:35:09 +0100 | Subject | Re: [PATCH v2 5/5] iio: afe: iio-rescale: Re-use generic struct s32_fract | From | Peter Rosin <> |
| |
On 2022-01-26 13:04, Andy Shevchenko wrote: > On Wed, Jan 26, 2022 at 11:26:50AM +0100, Peter Rosin wrote: >> It's easy to both remove and to add back "the bigger object". I just >> don't see the point of the churn. Technically you can probably rearrange >> stuff in probe and remove the 2nd argument to ->props() altogether and >> chase pointers from the dev object instead. I don't see the point of >> that either. It doesn't really make things simpler, it doesn't really >> make things easier to read. To me, it's just pointless churn. > > Since you still haven't got a point the conclusions are wrong. > The point is (I dunno how more clear to make it) is to have proper > layering from the (current) design perspective.
I think got the gist of it. I simply do not agree with your conclusion about what the "proper layering" should be.
Cheers, Peter
| |