Messages in this thread | | | From | Florian Weimer <> | Subject | Re: [RFC PATCH 02/15] rseq: Remove broken uapi field layout on 32-bit little endian | Date | Wed, 26 Jan 2022 12:00:55 +0100 |
| |
* Christian Brauner:
> On Tue, Jan 25, 2022 at 02:00:48PM -0500, Mathieu Desnoyers wrote: >> So users of the uapi rseq.h (as an API) can still use >> rseq_abi->rseq_cs before and after the change. >> >> Based on this, I am inclined to remove the union, and just make the >> rseq_cs field a __u64. >> >> Any objections ? > > I do like it fwiw. But since I haven't been heavily involved in the > userspace usage of this I can't speak confidently to the regression > potential of a change like this. But I would think that we should risk > it instead of dragging a pointless union around forever.
I don't think glibc needs changes for this, it will keep building just fine. We'll need to adjust the included kernel header fragment that could be used by applications in some corner cases, but that's it.
| |