lkml.org 
[lkml]   [2022]   [Jan]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3] irqchip/gic-v3-its: Reset each ITS's BASERn register before probe
On Wed, 26 Jan 2022 09:57:26 +0000,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> wrote:
>
> > static void __init its_acpi_probe(void)
> > {
> > acpi_table_parse_srat_its();
> > - acpi_table_parse_madt(ACPI_MADT_TYPE_GENERIC_TRANSLATOR,
> > - gic_acpi_parse_madt_its, 0);
> > + if (acpi_table_parse_madt(ACPI_MADT_TYPE_GENERIC_TRANSLATOR,
> > + its_acpi_reset, 0) > 0)
> > + acpi_table_parse_madt(ACPI_MADT_TYPE_GENERIC_TRANSLATOR,
> > + gic_acpi_parse_madt_its, 0);
>
> Maybe it is worth adding a comment here as you did for DT if you
> can before merging it - to clarify the first acpi_table_parse_madt()
> call logic.

Sure, I'll add that.

>
> Other than that:
>
> Reviewed-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>

Thanks,

M.

--
Without deviation from the norm, progress is not possible.

\
 
 \ /
  Last update: 2022-01-26 12:10    [W:0.041 / U:0.980 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site