lkml.org 
[lkml]   [2022]   [Jan]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 03/12] misc: fastrpc: Add support to get DSP capabilities
Hi Srinivas,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on char-misc/char-misc-testing]
[also build test WARNING on robh/for-next linux/master linus/master v5.17-rc1 next-20220125]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Srinivas-Kandagatla/misc-fastrpc-Add-missing-DSP-FastRPC-features/20220126-215705
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git 515a2f507491e7c3818e74ef4f4e088c1fecb190
config: nds32-randconfig-r014-20220126 (https://download.01.org/0day-ci/archive/20220127/202201270435.PxFnOyYn-lkp@intel.com/config)
compiler: nds32le-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/a22465bb4904facca8fe21d23f74410cf6cb1fd0
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Srinivas-Kandagatla/misc-fastrpc-Add-missing-DSP-FastRPC-features/20220126-215705
git checkout a22465bb4904facca8fe21d23f74410cf6cb1fd0
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=nds32 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

drivers/misc/fastrpc.c: In function 'fastrpc_req_mem_unmap_impl':
drivers/misc/fastrpc.c:1646:23: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
1646 | args[0].ptr = (u64) &req_msg;
| ^
drivers/misc/fastrpc.c: In function 'fastrpc_req_mem_map':
drivers/misc/fastrpc.c:1696:19: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
1696 | map->va = (void *) req.vaddrin;
| ^
drivers/misc/fastrpc.c:1701:23: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
1701 | args[0].ptr = (u64) &req_msg;
| ^
drivers/misc/fastrpc.c:1707:23: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
1707 | args[1].ptr = (u64) &pages;
| ^
drivers/misc/fastrpc.c:1710:23: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
1710 | args[2].ptr = (u64) &pages;
| ^
drivers/misc/fastrpc.c:1713:23: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
1713 | args[3].ptr = (u64) &rsp_msg;
| ^
drivers/misc/fastrpc.c: In function 'fastrpc_get_info_from_kernel.constprop':
>> drivers/misc/fastrpc.c:1437:1: warning: the frame size of 1080 bytes is larger than 1024 bytes [-Wframe-larger-than=]
1437 | }
| ^


vim +1437 drivers/misc/fastrpc.c

1400
1401 static int fastrpc_get_info_from_kernel(struct fastrpc_ioctl_capability *cap,
1402 struct fastrpc_user *fl)
1403 {
1404 struct fastrpc_channel_ctx *cctx = fl->cctx;
1405 uint32_t attribute_id = cap->attribute_id;
1406 uint32_t dsp_attributes[FASTRPC_MAX_DSP_ATTRIBUTES];
1407 unsigned long flags;
1408 uint32_t domain = cap->domain;
1409 int err;
1410
1411 spin_lock_irqsave(&cctx->lock, flags);
1412 /* check if we already have queried dsp for attributes */
1413 if (cctx->valid_attributes) {
1414 spin_unlock_irqrestore(&cctx->lock, flags);
1415 goto done;
1416 }
1417 spin_unlock_irqrestore(&cctx->lock, flags);
1418
1419 err = fastrpc_get_info_from_dsp(fl, &dsp_attributes[0], FASTRPC_MAX_DSP_ATTRIBUTES);
1420 if (err == DSP_UNSUPPORTED_API) {
1421 dev_info(&cctx->rpdev->dev,
1422 "Warning: DSP capabilities not supported on domain: %d\n", domain);
1423 return -EOPNOTSUPP;
1424 } else if (err) {
1425 dev_err(&cctx->rpdev->dev, "Error: dsp information is incorrect err: %d\n", err);
1426 return err;
1427 }
1428
1429 spin_lock_irqsave(&cctx->lock, flags);
1430 memcpy(cctx->dsp_attributes, dsp_attributes, sizeof(u32) * FASTRPC_MAX_DSP_ATTRIBUTES);
1431 cctx->valid_attributes = true;
1432 spin_unlock_irqrestore(&cctx->lock, flags);
1433 done:
1434 cap->capability = cctx->dsp_attributes[attribute_id];
1435
1436 return 0;
> 1437 }
1438

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

\
 
 \ /
  Last update: 2022-01-26 22:06    [W:0.553 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site