Messages in this thread | | | Subject | Re: [PATCH v7 2/5] powercap/drivers/dtpm: Add hierarchy creation | From | Daniel Lezcano <> | Date | Tue, 25 Jan 2022 18:53:43 +0100 |
| |
On 25/01/2022 18:36, Ulf Hansson wrote: > On Tue, 25 Jan 2022 at 18:18, Daniel Lezcano <daniel.lezcano@linaro.org> wrote: >> >> The DTPM framework is available but without a way to configure it. >> >> This change provides a way to create a hierarchy of DTPM node where >> the power consumption reflects the sum of the children's power >> consumption. >> >> It is up to the platform to specify an array of dtpm nodes where each >> element has a pointer to its parent, except the top most one. The type >> of the node gives the indication of which initialization callback to >> call. At this time, we can create a virtual node, where its purpose is >> to be a parent in the hierarchy, and a DT node where the name >> describes its path. >> >> In order to ensure a nice self-encapsulation, the DTPM subsys array >> contains a couple of initialization functions, one to setup the DTPM >> backend and one to initialize it up. With this approach, the DTPM >> framework has a very few material to export. >> >> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> >> Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org> > > Yes, this looks good to me now. Thanks for adopting my suggestions.
Thanks for your time to review the code
-- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
| |