lkml.org 
[lkml]   [2022]   [Jan]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 5.17-rc1 v2] eeprom: at25: Restore missing allocation
Hi Kees,

Thanks for your patch!

On Fri, Jan 21, 2022 at 12:33 AM Kees Cook <keescook@chromium.org> wrote:
> The at25 driver regressed in v5.17-rc1 due to a broken conflict
> resolution: the allocation of the object was accidentally removed. Restore
> it.
>
> This was found when building under CONFIG_FORTIFY_SOURCE=y and
> -Warray-bounds, which complained about strncpy() being used against an
> empty object:
>
> In function 'strncpy',
> inlined from 'at25_fw_to_chip.constprop' at drivers/misc/eeprom/at25.c:312:2:
> ./include/linux/fortify-string.h:48:33: warning: '__builtin_strncpy' offset [0, 9] is out of the bounds [0, 0] [-Warray-bounds]
> 48 | #define __underlying_strncpy __builtin_strncpy
> | ^
> ./include/linux/fortify-string.h:59:16: note: in expansion of macro '__underlying_strncpy'
> 59 | return __underlying_strncpy(p, q, size);
> | ^~~~~~~~~~~~~~~~~~~~
> In function 'strncpy',
> inlined from 'at25_fram_to_chip' at drivers/misc/eeprom/at25.c:373:2,
> inlined from 'at25_probe' at drivers/misc/eeprom/at25.c:453:10:
> ./include/linux/fortify-string.h:48:33: warning: '__builtin_strncpy' offset [0, 9] is out of the bounds [0, 0] [-Warray-bounds]
> 48 | #define __underlying_strncpy __builtin_strncpy
> | ^
> ./include/linux/fortify-string.h:59:16: note: in expansion of macro '__underlying_strncpy'
> 59 | return __underlying_strncpy(p, q, size);
> | ^~~~~~~~~~~~~~~~~~~~

On real hardware:

Unable to handle kernel access to user memory outside uaccess
routines at virtual address 0000000000000028
...
pc : __mutex_init+0x20/0x68
lr : at25_probe+0x8c/0x4d8


> Signed-off-by: Kees Cook <keescook@chromium.org>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

\
 
 \ /
  Last update: 2022-01-25 15:39    [W:1.356 / U:0.000 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site