lkml.org 
[lkml]   [2022]   [Jan]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3/9] selinux: declare name parameter of hash_eval const
    Date
    String literals are passed as second argument to hash_eval(). Also the
    parameter is already declared const in the DEBUG_HASHES configuration.

    Reported by clang [-Wwrite-strings]:

    security/selinux/ss/policydb.c:1881:26: error: passing 'const char [8]' to parameter of type 'char *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
    hash_eval(&p->range_tr, rangetr);
    ^~~~~~~~~
    security/selinux/ss/policydb.c:707:55: note: passing argument to parameter 'hash_name' here
    static inline void hash_eval(struct hashtab *h, char *hash_name)
    ^
    security/selinux/ss/policydb.c:2099:32: error: passing 'const char [11]' to parameter of type 'char *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
    hash_eval(&p->filename_trans, filenametr);
    ^~~~~~~~~~~~
    security/selinux/ss/policydb.c:707:55: note: passing argument to parameter 'hash_name' here
    static inline void hash_eval(struct hashtab *h, char *hash_name)
    ^

    Signed-off-by: Christian Göttsche <cgzones@googlemail.com>
    ---
    security/selinux/ss/policydb.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/security/selinux/ss/policydb.c b/security/selinux/ss/policydb.c
    index 0ae1b718194a..67e03f6e8966 100644
    --- a/security/selinux/ss/policydb.c
    +++ b/security/selinux/ss/policydb.c
    @@ -704,7 +704,7 @@ static void symtab_hash_eval(struct symtab *s)
    }

    #else
    -static inline void hash_eval(struct hashtab *h, char *hash_name)
    +static inline void hash_eval(struct hashtab *h, const char *hash_name)
    {
    }
    #endif
    --
    2.34.1
    \
     
     \ /
      Last update: 2022-01-25 15:20    [W:3.821 / U:0.240 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site