Messages in this thread | | | Date | Tue, 25 Jan 2022 15:48:32 +0300 | Subject | Re: [PATCH 05/10] staging: r8188eu: remove smaller sets of DBG_88E calls from os_dep dir | From | Pavel Skripkin <> |
| |
Hi Phillip,
On 1/25/22 01:44, Phillip Potter wrote: > Remove all DBG_88E calls from the os_dep directory, other than those in > os_dep/ioctl_linux.c, as this contains almost 200 on its own so will be > done in a separate patch for ease of review. These calls do not conform > to kernel coding standards and are superfluous. Also restructure where > appropriate to remove no longer needed code left behind by removal of > these calls. This will allow the eventual removal of the DBG_88E macro > itself. > > Signed-off-by: Phillip Potter <phil@philpotter.co.uk> > ---
[code snip]
> > - /* 2012-07-11 Move here to prevent the 8723AS-VAU BT auto > - * suspend influence */ > - if (usb_autopm_get_interface(pusb_intf) < 0) > - DBG_88E("can't get autopm:\n"); > -
Didn't you make a function change here? I didn't test and also didn't find any mentions of tests in cover letter.
I am asking just to be sure you done it not by accident :)
With regards, Pavel Skripkin
| |