lkml.org 
[lkml]   [2022]   [Jan]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 05/10] staging: r8188eu: remove smaller sets of DBG_88E calls from os_dep dir
From
Hi Phillip,

On 1/25/22 01:44, Phillip Potter wrote:
> Remove all DBG_88E calls from the os_dep directory, other than those in
> os_dep/ioctl_linux.c, as this contains almost 200 on its own so will be
> done in a separate patch for ease of review. These calls do not conform
> to kernel coding standards and are superfluous. Also restructure where
> appropriate to remove no longer needed code left behind by removal of
> these calls. This will allow the eventual removal of the DBG_88E macro
> itself.
>
> Signed-off-by: Phillip Potter <phil@philpotter.co.uk>
> ---

[code snip]

>
> - /* 2012-07-11 Move here to prevent the 8723AS-VAU BT auto
> - * suspend influence */
> - if (usb_autopm_get_interface(pusb_intf) < 0)
> - DBG_88E("can't get autopm:\n");
> -

Didn't you make a function change here? I didn't test and also didn't
find any mentions of tests in cover letter.

I am asking just to be sure you done it not by accident :)





With regards,
Pavel Skripkin

\
 
 \ /
  Last update: 2022-01-25 14:06    [W:0.217 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site