Messages in this thread | | | Subject | Re: [PATCH] ata: pata_platform: Fix a NULL pointer dereference in __pata_platform_probe() | From | Sergey Shtylyov <> | Date | Tue, 25 Jan 2022 12:46:56 +0300 |
| |
On 1/24/22 7:45 PM, Zhou Qingyang wrote:
> In __pata_platform_probe(), devm_kzalloc() is assigned to ap->ops and > there is a dereference of it right after that, which could introduce a > NULL pointer dereference bug. > > Fix this by adding a NULL check of ap->ops. > > This bug was found by a static analyzer. > > Builds with 'make allyesconfig' show no new warnings, > and our static analyzer no longer warns about this code. > > Fixes: f3d5e4f18dba ("ata: pata_of_platform: Allow to use 16-bit wide data transfer") > Signed-off-by: Zhou Qingyang <zhou1615@umn.edu>
Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
[...]
MBR, Sergey
| |