Messages in this thread | | | Date | Mon, 24 Jan 2022 21:50:25 -0800 | From | Eric Biggers <> | Subject | Re: [PATCH v2] arm64: dts: qcom: sm8350: Correct UFS symbol clocks |
| |
On Wed, Dec 22, 2021 at 08:20:58AM -0800, Bjorn Andersson wrote: > The introduction of '9a61f813fcc8 ("clk: qcom: regmap-mux: fix parent > clock lookup")' broke UFS support on SM8350. > > The cause for this is that the symbol clocks have a specified rate in > the "freq-table-hz" table in the UFS node, which causes the UFS code to > request a rate change, for which the "bi_tcxo" happens to provide the > closest rate. Prior to the change in regmap-mux it was determined > (incorrectly) that no change was needed and everything worked. > > The rates of 75 and 300MHz matches the documentation for the symbol > clocks, but we don't represent the parent clocks today. So let's mimic > the configuration found in other platforms, by omitting the rate for the > symbol clocks as well to avoid the rate change. > > While at it also fill in the dummy symbol clocks that was dropped from > the GCC driver as it was upstreamed. > > Fixes: 59c7cf814783 ("arm64: dts: qcom: sm8350: Add UFS nodes") > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> > ---
Tested-by: Eric Biggers <ebiggers@google.com>
This was sent out over a month ago. Can it be applied? It is annoying having master as well as v5.16 be broken on SM8350.
- Eric
| |