Messages in this thread | | | Date | Tue, 25 Jan 2022 16:27:32 +0800 | From | kernel test robot <> | Subject | Re: [PATCH 04/10] staging: r8188eu: remove all DBG_88E calls from hal dir |
| |
Hi Phillip,
I love your patch! Perhaps something to improve:
[auto build test WARNING on staging/staging-testing] [also build test WARNING on v5.17-rc1 next-20220124] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Phillip-Potter/Cleanup-and-removal-of-DBG_88E-macro/20220125-125206 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git fa783154524a71ab74e293cd8251155e5971952b config: arc-allyesconfig (https://download.01.org/0day-ci/archive/20220125/202201251642.5tYQO4Fb-lkp@intel.com/config) compiler: arceb-elf-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/041fe115dad9245f83646e7674341f28094d62a5 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Phillip-Potter/Cleanup-and-removal-of-DBG_88E-macro/20220125-125206 git checkout 041fe115dad9245f83646e7674341f28094d62a5 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arc SHELL=/bin/bash drivers/staging/r8188eu/
If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
drivers/staging/r8188eu/hal/rtl8188e_cmd.c: In function 'rtl8188e_set_FwMediaStatus_cmd': >> drivers/staging/r8188eu/hal/rtl8188e_cmd.c:195:20: warning: variable 'macid' set but not used [-Wunused-but-set-variable] 195 | u8 opmode, macid; | ^~~~~ >> drivers/staging/r8188eu/hal/rtl8188e_cmd.c:195:12: warning: variable 'opmode' set but not used [-Wunused-but-set-variable] 195 | u8 opmode, macid; | ^~~~~~
vim +/macid +195 drivers/staging/r8188eu/hal/rtl8188e_cmd.c
8cd574e6af5463 Phillip Potter 2021-07-28 192 8cd574e6af5463 Phillip Potter 2021-07-28 193 void rtl8188e_set_FwMediaStatus_cmd(struct adapter *adapt, __le16 mstatus_rpt) 8cd574e6af5463 Phillip Potter 2021-07-28 194 { 8cd574e6af5463 Phillip Potter 2021-07-28 @195 u8 opmode, macid; 8cd574e6af5463 Phillip Potter 2021-07-28 196 u16 mst_rpt = le16_to_cpu(mstatus_rpt); 8cd574e6af5463 Phillip Potter 2021-07-28 197 opmode = (u8)mst_rpt; 8cd574e6af5463 Phillip Potter 2021-07-28 198 macid = (u8)(mst_rpt >> 8); 8cd574e6af5463 Phillip Potter 2021-07-28 199 8cd574e6af5463 Phillip Potter 2021-07-28 200 FillH2CCmd_88E(adapt, H2C_COM_MEDIA_STATUS_RPT, sizeof(mst_rpt), (u8 *)&mst_rpt); 8cd574e6af5463 Phillip Potter 2021-07-28 201 } 8cd574e6af5463 Phillip Potter 2021-07-28 202
--- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
| |