Messages in this thread | | | Date | Mon, 24 Jan 2022 22:40:42 -0800 | From | Eric Biggers <> | Subject | Re: [PATCH v2] lib/crypto: blake2s: avoid indirect calls to compression function for Clang CFI |
| |
On Mon, Jan 24, 2022 at 08:28:49PM +0100, Jason A. Donenfeld wrote: > blake2s_compress_generic is weakly aliased by blake2s_generic. The
Don't you mean "weakly aliased by blake2s_compress"?
> Fixes: 6048fdcc5f26 ("lib/crypto: blake2s: include as built-in") > Reported-by: Miles Chen <miles.chen@mediatek.com> > Tested-by: Miles Chen <miles.chen@mediatek.com> > Tested-by: Nathan Chancellor <nathan@kernel.org> > Link: https://github.com/ClangBuiltLinux/linux/issues/1567 > Cc: Nick Desaulniers <ndesaulniers@google.com> > Cc: Sami Tolvanen <samitolvanen@google.com> > Cc: Ard Biesheuvel <ardb@kernel.org> > Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com> > ---
Otherwise this looks fine, though it's unfortunate this is needed. You can add:
Reviewed-by: Eric Biggers <ebiggers@google.com>
> Changes v1->v2: > - Wrapped columns at 80 for Eric.
It is the recommended coding style, so not just for me :-)
- Eric
| |