Messages in this thread | | | Date | Wed, 26 Jan 2022 10:32:47 +0800 | Subject | Re: [RESEND][PATCH] Documentation: added order requirement for ima_hash= | From | "Guozihua (Scott)" <> |
| |
On 2022/1/26 8:14, Jonathan Corbet wrote: > GUO Zihua <guozihua@huawei.com> writes: > >> From: Guo Zihua <guozihua@huawei.com> >> >> Commandline parameter ima_hash= and ima_template= has order requirement >> for them to work correctly together. Namely ima_hash= must be >> specified after ima_template=, otherwise ima_template= will be ignored. >> >> The reason is that when handling ima_hash=, ima template would be set to >> the default value if it has not been initialized already, and that value >> cannot be changed afterwards by ima_template=. >> >> This patch adds this limitation to the documentation. >> >> Reviewed-by: Roberto Sassu <roberto.sassu@huawei.com> >> Signed-off-by: Guo Zihua <guozihua@huawei.com> > > I've applied this, but I'm wondering: where did this review take place? > I can't find it on the lists... > > Thanks, > > jon > .
Hi Jonathan,
Thank you very much and sorry for the confusion here. The reviewed by is more like a face-to-face peer review and I would like to mention that in the patch. If this is problematic I would stop doing that from now on.
-- Best GUO Zihua
| |