Messages in this thread | | | Date | Tue, 25 Jan 2022 19:21:12 -0700 | Subject | Re: [PATCH net-next 4/6] net: ipv4: use kfree_skb_reason() in ip_protocol_deliver_rcu() | From | David Ahern <> |
| |
On 1/24/22 6:15 AM, menglong8.dong@gmail.com wrote: > diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h > index 8942d32c0657..603f77ef2170 100644 > --- a/include/linux/skbuff.h > +++ b/include/linux/skbuff.h > @@ -328,6 +328,8 @@ enum skb_drop_reason {
It would be worthwhile to document the meaning of these as you add them -- long description of the enum.
> SKB_DROP_REASON_IP_RPFILTER, > SKB_DROP_REASON_EARLY_DEMUX, > SKB_DROP_REASON_UNICAST_IN_L2_MULTICAST,
/* xfrm policy check failed */ > + SKB_DROP_REASON_XFRM_POLICY,
/* no support for IP protocol */ > + SKB_DROP_REASON_IP_NOPROTO, > SKB_DROP_REASON_MAX, > }; >
If the enum is 1:1 with an SNMP counter, just state that.
| |