Messages in this thread | | | From | Paul Moore <> | Date | Tue, 25 Jan 2022 19:35:59 -0500 | Subject | Re: [PATCH 1/9] selinux: check return value of sel_make_avc_files |
| |
On Tue, Jan 25, 2022 at 9:15 AM Christian Göttsche <cgzones@googlemail.com> wrote: > > sel_make_avc_files() might fail and return a negative errno value on > memory allocation failures. Re-add the check of the return value, > dropped in 66f8e2f03c02. > > Reported by clang-analyzer: > > security/selinux/selinuxfs.c:2129:2: warning: Value stored to 'ret' is never read [deadcode.DeadStores] > ret = sel_make_avc_files(dentry); > ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~ > > Fixes: 66f8e2f03c02 ("selinux: sidtab reverse lookup hash table") > Signed-off-by: Christian Göttsche <cgzones@googlemail.com> > --- > security/selinux/selinuxfs.c | 2 ++ > 1 file changed, 2 insertions(+)
Merged into selinux/next, thanks Christian.
-- paul-moore.com
| |