Messages in this thread | | | Subject | Re: [PATCH 3/3] selftests/zram: Adapt the situation that /dev/zram0 is being used | From | Shuah Khan <> | Date | Tue, 25 Jan 2022 13:40:25 -0700 |
| |
On 12/15/21 2:56 AM, Yang Xu wrote: > On some linux distributions, if it used /dev/zram0 as default by zram-generate > service, then this case will fail or report EBUSY. > > To fix this, use hot_add/hot_remove interface. Also, move module check code into > zram_load from zram.sh. We can use /sys/class/zram-control to detect the > module whether existed. > > After this patch, we still run case pass even /dev/zram0 is being used. > > Signed-off-by: Yang Xu <xuyang2018.jy@fujitsu.com> > --- > tools/testing/selftests/zram/zram.sh | 16 +---- > tools/testing/selftests/zram/zram01.sh | 2 +- > tools/testing/selftests/zram/zram_lib.sh | 75 ++++++++++++------------ > 3 files changed, 41 insertions(+), 52 deletions(-) >
This patch looks good to me. A few checkpatch warns to fix and also it probably depends on the other two patches in this series.
Please fix and send v2 for all 3 patches.
thanks, -- Shuah
| |