Messages in this thread | | | From | Thinh Nguyen <> | Subject | Re: [PATCH v2 4/7] usb: dwc3: Program GFLADJ | Date | Tue, 25 Jan 2022 20:02:43 +0000 |
| |
Felipe Balbi wrote: > > Hi, > > Thinh Nguyen <Thinh.Nguyen@synopsys.com> writes: >>> On 1/24/22 5:46 PM, Thinh Nguyen wrote: >>>> Sean Anderson wrote: >>>>> diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c >>>>> index 5214daceda86..883e119377f0 100644 >>>>> --- a/drivers/usb/dwc3/core.c >>>>> +++ b/drivers/usb/dwc3/core.c >>>>> @@ -348,7 +348,7 @@ static void dwc3_frame_length_adjustment(struct dwc3 *dwc) >>>>> static void dwc3_ref_clk_period(struct dwc3 *dwc) >>>>> { >>>>> u32 reg; >>>>> - unsigned long rate, period; >>>>> + unsigned long decr, fladj, rate, period; >>>> >>>> Minor style nit: Felipe prefers to keep the declaration on separate >>>> lines, let's keep it consistent with the rest in this driver. >>> >>> So >>> >>> unsigned int decr; >>> unsigned int fladj; >>> unsigned int rate; >>> unsigned int period; >>> >>> ? >>> >>> Frankly that seems rather verbose. >> >> A couple of the benefits of having it like this is to help with viewing >> git-blame if we introduce new variables and help with backporting fix > > it also prevents single lines from being constantly modified just > because we're adding a new variable. In the diff, adding a new variable > should look like a new line being added, rather than modified. >
Right.
>> patch a bit simpler. Mainly I'm just following Felipe's style and keep > > it's part of the kernel coding style, actually :-) >
Glad to see you're here :)
BR, Thinh
| |