lkml.org 
[lkml]   [2022]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 2/2] Revert "fbcon: Disable accelerated scrolling"
    Hi Helge,

    On Mon, Jan 24, 2022 at 4:30 PM Helge Deller <deller@gmx.de> wrote:
    > On 1/24/22 12:50, Javier Martinez Canillas wrote:
    > > On 1/24/22 12:33, Thomas Zimmermann wrote:
    > >
    > > [snip]
    > >
    > >>> Thoughts?
    > >>
    > >> I can't say I approve keeping fbdev alive, but...
    > >>
    > >> With fbdev emulation, every DRM driver is an fbdev driver too. So
    > >> CONFIG_FB_DRIVER is somewhat misleading. Better add an option like
    > >> CONFIG_FBCON_HW_SCROLLING and have it selected by the fbdev drivers that
    > >> absolutely need HW acceleration. That option would then protect the rsp
    > >> code.
    >
    > I'm not a fan of something like CONFIG_FBCON_HW_SCROLLING, but I'm not
    > against it either.
    > For me it sounds that this is not the real direction you want to go,
    > which is to prevent that any other drivers take the framebuffer before
    > you take it with simpledrm or similiar.
    > CONFIG_FBCON_HW_SCROLLING IMHO just disables the (from your POV) neglectable accleration part.
    > With an option like CONFIG_FB_DRIVER (maybe better: CONFIG_FB_LEGACY_DRIVERS)
    > it's an easy option for distros to disable all of the legacy drivers
    > from being built & shipped.
    >
    > Instead of CONFIG_FBCON_HW_SCROLLING we could also choose
    > CONFIG_FBCON_LEGACY_ACCELERATION, because it includes fillrect() as well...

    As this is about resurrecting features indicated by the various
    FBINFO_HWACCEL_* flags, what about CONFIG_FB_HWACCEL?

    Gr{oetje,eeting}s,

    Geert

    --
    Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

    In personal conversations with technical people, I call myself a hacker. But
    when I'm talking to journalists I just say "programmer" or something like that.
    -- Linus Torvalds

    \
     
     \ /
      Last update: 2022-01-24 16:51    [W:2.556 / U:0.260 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site