lkml.org 
[lkml]   [2022]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.16 0827/1039] tracing/uprobes: Check the return value of kstrdup() for tu->filename
    Date
    From: Xiaoke Wang <xkernel.wang@foxmail.com>

    [ Upstream commit 8c7224245557707c613f130431cafbaaa4889615 ]

    kstrdup() returns NULL when some internal memory errors happen, it is
    better to check the return value of it so to catch the memory error in
    time.

    Link: https://lkml.kernel.org/r/tencent_3C2E330722056D7891D2C83F29C802734B06@qq.com

    Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
    Fixes: 33ea4b24277b ("perf/core: Implement the 'perf_uprobe' PMU")
    Signed-off-by: Xiaoke Wang <xkernel.wang@foxmail.com>
    Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    kernel/trace/trace_uprobe.c | 5 +++++
    1 file changed, 5 insertions(+)

    diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
    index f5f0039d31e5a..78ec1c16ccf4b 100644
    --- a/kernel/trace/trace_uprobe.c
    +++ b/kernel/trace/trace_uprobe.c
    @@ -1619,6 +1619,11 @@ create_local_trace_uprobe(char *name, unsigned long offs,
    tu->path = path;
    tu->ref_ctr_offset = ref_ctr_offset;
    tu->filename = kstrdup(name, GFP_KERNEL);
    + if (!tu->filename) {
    + ret = -ENOMEM;
    + goto error;
    + }
    +
    init_trace_event_call(tu);

    ptype = is_ret_probe(tu) ? PROBE_PRINT_RETURN : PROBE_PRINT_NORMAL;
    --
    2.34.1


    \
     
     \ /
      Last update: 2022-09-17 16:14    [W:3.310 / U:1.896 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site